search

yob / pdf-reader

The PDF::Reader library implements a PDF parser conforming as much as possible to the PDF specification from Adobe.
MIT License
1.81k stars 271 forks source link

restore sorbet check for dead code #396

Closed yob closed 2 years ago

yob commented 2 years ago

Originally disabled in PR #395, but I got some advice on how to re-enable it on stackoverflow.

I'm not sure I even want this kind of check really, given how inconsistently they're used across the codebase. Maybe they have value, but only on the public API? Anyway, for now I'm focused on defining types in Sorbet rather than changing behaviour.