yobgob / too-many-hooks

Opinionated collection of typed React hooks
https://yobgob.dev/too-many-hooks/
Apache License 2.0
3 stars 5 forks source link

Consolidate story definitions in mdx files #17

Closed dawsonbooth closed 1 year ago

dawsonbooth commented 1 year ago
github-actions[bot] commented 1 year ago

PR Preview Action v1.2.0 :---: Preview removed because the pull request was closed. 2023-01-15 04:20 UTC

PatrickDeVries commented 1 year ago

What is the rationale for moving the story definitions into the MDX? Could be a config issue but I opted out of doing this initially because I get no auto-formatting, type inference, auto imports, etc in MDX files through vscode so I thought building the stories in a TSX file where we get those features would be preferable. I do get a little linting such as warnings about things being undefined but that is all. If you are getting those features in the MDX then I'm happy to do this but we need to debug why that stuff does not work on my IDE. Otherwise, I think it is preferable to keep them separate so story development has IDE features and docs can just grab the story by ID as we were doing.