yobson1 / FavCat-Restored

FavCat but restoring the favorite functionality without VRChat+
GNU General Public License v3.0
23 stars 1 forks source link

[BUG] Local Favorite #3

Closed IamLupo closed 2 years ago

IamLupo commented 2 years ago

When i try to add a world to "Local favorite" it doesn't get displayed in that group. It looks like the world is added in the background but just not displayed. I notice this issue doesnt happen to all worlds.

These worlds doesn't work as example: https://en.vrcw.net/world/detail/wrld_58e5a8a7-100f-4346-85e1-a6e00d871c61 https://en.vrcw.net/world/detail/wrld_da1b9df3-f10f-43e4-9fe8-42adda87d159

Screenshots

You see i added to world to "Local Favorite" Picture 1

You see here the world is not in the list: Picture 2

Questions:

Here my Melonloader log: Latest.log

yobson1 commented 2 years ago

Thanks for the bug report. Issue was that the stored worlds was no longer being updated due to the method being sniffed to log them no longer actually including ApiWorld responses. This meant that only worlds that were already in your store DB were able to be favourited, newer ones were not. I've switched which method is being sniffed and this one seems to include worlds fine and fixes the issue. Fix will be included in the next release, which should be soon.

HeyImRuu commented 2 years ago

Hi the new method appears to not include ApiAvatar responses, and now this bug affects avatars rather than worlds

IamLupo commented 2 years ago

Hi the new method appears to not include ApiAvatar responses, and now this bug affects avatars rather than worlds

Avatars just works fine for me...

yobson1 commented 2 years ago

Hi the new method appears to not include ApiAvatar responses, and now this bug affects avatars rather than worlds

I'm not able to replicate either, if you continue to have issues please create a new issue with some more details of what's going wrong. Include any errors/melon loader log if applicable.