search

yocarrotyo / HammockHelper

Hammock Helper is a java-based webapp for looking up hammock-friendly campsites at state parks in Wisconsin. Registered users can also add data about sites they're familiar with and help with validation of other users' submissions. Never pack a tent again!
http://3.12.23.13:8080/HammockHelper/
0 stars 0 forks source link

Peer Review 1 #2

Open NotSoFearfulSymmetry opened 4 years ago

NotSoFearfulSymmetry commented 4 years ago

Design/Code Review 1

Project: Hammock Helper

Developer: Caroline Hughes

Reviewer: Simon Powers-Schaub

Item Considerations Comments/Suggestions
Reviewer comments and suggestions go here. Each item should have at least one "kudos" and two suggestions for improvement
Problem Statement 1. Accurately describes project purpose
2. Is professional and free of typos, slang, etc.
3. Fully explains the problem and the solution
4. Is understandable by the average person		 Clear and specific.
Design Documentation 1. Navigation/flow through the application is logical and easy to use.
2. The order in which values are displayed are logical and easy to understand/use
3. The order in which the form fields entered are logical and easy to understand/use
4. All data discussed/documented (problem statement, flow, db design, etc.) is represented on the screens		 Detailed and easy-to-grasp screens.
What's the flow between them?
What's the mobile layout?
Data model/Database 1. Everything on the screens and problem statement/flow is represented in the model
2. There is at least one 1-to-many relationship.
3. The model represents good database design
Code 1. Proper Maven project structure is used
2. a .gitignore file for IntelliJ Java projects has been implemented
3. There is not any redundant or copy/paste code in the JSPs or classes
4. Classes are appropriately-sized (no monster classes)
Property files are used appropriately: no hard-coded values
5. Logging statements are used rather than System.out.println and printStackTrace.
6. There are appropriate unit tests/code coverages.		 Clear and straightforward. (I regret the lack of specificity in these comments, but if you'd like more detailed feedback, we can discuss the matter through Slack, or some other channel that doesn't rely on screen-sharing).
pawaitemadisoncollege commented 4 years ago

@NotSoFearfulSymmetry Regarding Code feedback - you can view code directly in Github if you weren't able to review it together last night. When doing the code review portion, did you find any printStackTrace statements or printlns? If so, please indicate where so @yocarrotyo can easily fix them. If not, indicate none were found. Hint: the search feature is in Github can be useful for finding these. Was the .gitignore there? Classes sizes ok? Any redundancy?

NotSoFearfulSymmetry commented 4 years ago

Two printStacktrace statements in Database.java. The .gitignore is present, and the classes look to be good sizes. There is some redundancy in the DAOs; perhaps a generic DAO could address this.