search

yochananrachamim / AzureSQL

129 stars 61 forks source link

Use constants instead of fixed values #21

Closed tbolon closed 2 years ago

tbolon commented 3 years ago

When using smart index analysis, the fragmentation values are hard-coded and reused multiple times inside the code. This change simply create constants and use them instead of fixed values. The goal is not to expose (yet) these values, only to allow users to change them if needed or for testing purposes.

yochananrachamim commented 2 years ago

Hi Thomas, Yes, I agree we should do that at some point in time. I cannot merge the pull request as there is a wrong replacement there, when checking for server version... as it contains the number 5 I guess it was changed with "change all"

I'm happy however to implement it in the code.

Thank you so much for sharing your idea with me.

Yochanan.

tbolon commented 2 years ago

Thank you for accepting my contribution, and thank you for this useful script :)