Closed GoogleCodeExporter closed 9 years ago
I'm a bit skeptical of this. Does it actually work for multiple files? In
particular, I'm really pretty sure that
rm "file1 file1"
will not do what we want - it will try to find a single file named "file1
file2", so this fix is broken.
Note that $(wildcard $1) returns a space-separated list of files.
I think it's actually fine to simply not support files with ( and ) in their
names.
Original comment by shiblon
on 7 Nov 2012 at 9:33
You are right. I was too hasty. It doesn't not work for the cases you
pointed out. Also, it appears that GNU make has some serious troubles
handling file-names with spaces AND these special characters.
Original comment by gsbabil
on 7 Nov 2012 at 12:51
I just added the following to support deleting user-defined files. The variable
'clean_userdefined' can be specified in 'Makefile.ini' or 'Variables.ini' to
perform cleaning of user-defined files.
===================================================================
.PHONY: clean-nographics
clean-nographics: clean-tex clean-deps clean-backups clean-auxiliary ;
+.PHONY: clean-userdefined
+clean-userdefined:
+ $(QUIET)$(call clean-files,$(clean_userdefined))
+
.PHONY: clean
-clean: clean-generated clean-tex clean-graphics clean-deps clean-backups
clean-auxiliary ;
+clean: clean-generated clean-tex clean-graphics clean-deps clean-backups
clean-auxiliary clean-userdefined;
#
# HELP TARGETS
===================================================================
Original comment by gsbabil
on 7 Nov 2012 at 1:17
I'm accepting this patch, but calling it "CLEAN_EXTRA". I'll ping this bug when
it's submitted.
Original comment by shiblon
on 23 Nov 2012 at 3:02
Actually, I'm going to just call it cleanextra (the variable, not the target -
the target will be clean-extra).
Original comment by shiblon
on 23 Nov 2012 at 3:04
rd13ff27c27be has the fix.
Original comment by shiblon
on 23 Nov 2012 at 3:08
Original issue reported on code.google.com by
gsbabil
on 7 Nov 2012 at 1:59