search

yocontra / node-gdal-next

Node.js bindings for GDAL (Geospatial Data Abstraction Library) [Fork]
https://contra.io/node-gdal-next/
Apache License 2.0
75 stars 35 forks source link

fix const char* warnings #24

Closed mmomtchev closed 3 years ago

mmomtchev commented 3 years ago

Fix const char warnings, GDAL usually returns const char strings to avoid mallocs

yocontra commented 3 years ago

@mmomtchev Sorry I was a bit hasty with the merge and went ahead with it while half of the tests on travis-ci were still pending - there are failures in CI if you can to address those in a new PR: https://travis-ci.org/github/contra/node-gdal-next/builds/733941859

mmomtchev commented 3 years ago

OGRSpatialReference::importFromWkt (const char **ppszInput) has const since GDAL 2.3, it is the builds against the shared version on older distributions that are failing I will see if I can find a clever way to do both, otherwise maybe just drop that changeset, it is not worth it to introduce complexity because of a warning