Missing semi colons in type

yocontra / react-responsive

CSS media queries in react - for responsive design, and more.

https://contra.io/react-responsive

MIT License

7.04k stars 298 forks source link

Missing semi colons in type #315

Closed kvaithin closed 1 year ago

kvaithin commented 1 year ago

Hi team, seeing following error when I build my project.

node_modules/react-responsive/types/index.d.ts(6,13): error TS1005: ';' expected.
node_modules/react-responsive/types/index.d.ts(6,118): error TS1005: ';' expected.

Looking through the project, looks like the norm in this project is to not use semi colons. Thus don't believe raising a PR to fix this would be the right approach.

Is there a way I could exclude the checks for this in my typescript react based project? Thanks.

yocontra commented 1 year ago

You should configure your linter rules to not check node_modules - this should already be the default behavior of every linter, so you may have misconfigured it somehow. If your linter is reading through node_modules it will be extremely slow and waste a lot of resources.