search

yoctoproject / vscode-bitbake

Bitbake language support for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=yocto-project.yocto-bitbake
Other
44 stars 10 forks source link

Fix: Ignore unsupported diagnostic sources #234

Closed idillon-sfl closed 4 months ago

idillon-sfl commented 5 months ago

Following this issue: https://github.com/yoctoproject/vscode-bitbake/issues/233

This simply ignore diagnostics from sources that we don't support, such as Pylint and flake8, in order to avoid irrelevant diagnostics.

deribaucourt commented 5 months ago

Where the diagnostics really unusable with these extensions? If it has false positives, but most ok, we could rather provide this as an option. There's already the option to disable all embedded languages features. Or to also disable these extensions in the workspace. If indeed, most diagnostics are false postiives, then filtering sounds nice. You could do the same on bash. (bash-ide + shellcheck OK)

idillon-sfl commented 5 months ago

I see this as a quick fix. Currently these extensions generate a lot of junk on BitBake files, and filtering only what's relevant might require some effort. However, it might be worthwhile to eventually support them properly. This is something we might want to discuss further.

This PR supports shellcheck. I've not added Bash IDE because it generates only one diagnostic and it does not seem relevant for BitBake.

deribaucourt commented 5 months ago

Closes #233