search

yoctoproject / vscode-bitbake

Bitbake language support for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=yocto-project.yocto-bitbake
Other
41 stars 10 forks source link

Use one wasm update workflow #246

Closed WilsonZiweiWang closed 2 months ago

WilsonZiweiWang commented 2 months ago

Use stragegy.matrix property to run the job repeatedly with a list of variables

WilsonZiweiWang commented 2 months ago

Can you make a test run before merging?

Here is the run that shows 2 workflows were triggered. For testing purposes, I added on pull_request so it can trigger this new workflow when I push changes to this PR. However, workflows triggered this way can't create another pull request because Github restricts permissions assigned to GITHUB_TOKEN. So I couldn't demo them. There was no such problem because old workflows were triggered by the workflow_call which inherited the caller workflow's permissions, and the caller workflow was triggered by the scheduled event, which gave it full permissions.

deribaucourt commented 2 months ago

Can you make a test run before merging?

Here is the run that shows 2 workflows were triggered. For testing purposes, I added on pull_request so it can trigger this new workflow when I push changes to this PR. However, workflows triggered this way can't create another pull request because Github restricts permissions assigned to GITHUB_TOKEN. So I couldn't demo them. There was no such problem because old workflows were triggered by the workflow_call which inherited the caller workflow's permissions, and the caller workflow was triggered by the scheduled event, which gave it full permissions.

GITHUB_TOKEN issues are expected when running on PRs instead of staging/main branch. Sounds good!