search

yodalee / mozc

Mozc - a Japanese Input Method Editor designed for multi-platform
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

mac/ActivatePane: Memory leaks? #72

Open yodalee opened 6 years ago

yodalee commented 6 years ago 
It looks like in mac/ActivatePane/ActivatePane.m, CFObjects created by 
functions that include Create in their names are not released by CFRelease. 
Basically, I think the CFObjects need to be released by CFRelease.
Please check the attached patch.

Also, please check the Create rule at:
https://developer.apple.com/library/mac/documentation/corefoundation/Conceptual/
CFMemoryMgmt/Concepts/Ownership.html#//apple_ref/doc/uid/20001148-103029

What version of the product are you using? On what operating system?
r251 on OS X 10.9.4.

Original issue reported on code.google.com by tetsuoki...@gmail.com on 5 Jul 2014 at 5:39

Attachments:

yodalee commented 6 years ago 
Thank you for the report.  We will take a look at that code.
Unfortunately we are not accepting external patches at this moment but I'll 
keep you updated when the code is updated.

Thanks!

Original comment by yukawa@google.com on 5 Jul 2014 at 7:58

yodalee commented 6 years ago 
Okay. Sounds good :)

Original comment by tetsuoki...@gmail.com on 5 Jul 2014 at 8:27