lib: use ANDROID_ADB_SERVER_PORT optionally

yodaos-project / yoda-platform-tools

Tools to interact with YodaOS devices 🛠

Apache License 2.0

8 stars 3 forks source link

lib: use ANDROID_ADB_SERVER_PORT optionally #6

Open xqbumu opened 5 years ago

xqbumu commented 5 years ago

Add gengrateADBClient in lib/common.ts to enable use env variable ANDROID_ADB_SERVER_PORT.

Checklist

[x] npm test passes
[ ] tests and/or benchmarks are included
[ ] documentation is changed or added

legendecas commented 5 years ago

Thank you for your swift proposing of PR 👍. It looks awesome to me.

But since package yoda-platform-lib is designed to be embedded into other tools like yoda-cli and yoda-vscode, I'd suggest exposing options of adb.createClient with PlatformSelector/PlatformClient constructor parameters.