search

yodaos-project / yoda.js

Application Framework that powered YodaOS
Apache License 2.0
187 stars 48 forks source link

lightd: do not init prepared audio if `player.lightd.holdcon` is 0 #873

Closed yorkie closed 4 years ago

yorkie commented 4 years ago

sounder.init holds the connection to pulseaudio, and it would keep writing empty buffers to alsa.

Checklist
codecov[bot] commented 4 years ago

Codecov Report

Merging #873 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #873   +/-   ##
=======================================
  Coverage   71.96%   71.96%           
=======================================
  Files          60       60           
  Lines        2418     2418           
=======================================
  Hits         1740     1740           
  Misses        678      678

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d0f6827...8f294f3. Read the comment docs.