search

yodaos-project / yoda.js

Application Framework that powered YodaOS
Apache License 2.0
187 stars 48 forks source link

pony: backport #883 into v7.x-staging partially #887

Closed yorkie closed 5 years ago

yorkie commented 5 years ago

This adds the unit-tests and only land pony-related changes on v7.x-staging.

Checklist
codecov[bot] commented 5 years ago

Codecov Report

Merging #887 into v7.x-staging will decrease coverage by 0.6%. The diff coverage is 8.33%.

Impacted file tree graph

@@               Coverage Diff                @@
##           v7.x-staging     #887      +/-   ##
================================================
- Coverage         66.46%   65.85%   -0.61%     
================================================
  Files                23       23              
  Lines              1136     1148      +12     
================================================
+ Hits                755      756       +1     
- Misses              381      392      +11
Impacted Files Coverage Δ
packages/@yoda/util/fs.js 12.12% <8.33%> (-2.17%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 32ceec2...ad3322a. Read the comment docs.

yorkie commented 5 years ago

The codecov fails because we don't have tests on packages/@yoda/util/fs.js, just skip them for now :)

yorkie commented 5 years ago

Restart a new Job: https://ci.rokid.com/job/rokid-ci-yodart-unit-tests/1472/console

yorkie commented 5 years ago

Rebased with the latest v7.x-staging to fix YodaOS CI failure on httpdns.