search

yodarunamok / fxphp

FX.php -- The best way from FileMaker to the Web
http://fx.iviking.org/
44 stars 29 forks source link

remove unneeded curl option #13

Closed ecsos closed 11 years ago

ecsos commented 12 years ago

The way we are using dataURL right now there is no need for this code. Also, using rawurlencode for this curl option seems to break the request when using characters like ! or # in the password whereas it doesn't break it for the dataURL because it is really a url.

An alternative fix would be to remove the rawurlencode from only the curl_setopt for CURLOPT_USERPWD.

yodarunamok commented 12 years ago

I don't think the solution is to remove the authentication code entirely, though... (At least, that's what the diff looks like.) I think I prefer the alternative fix you propose.

ecsos commented 12 years ago

Yeah that's fine with me, just that the dataURL already contains something like https://username:pwd@host which is essentially the same thing. seems redundant.

matsuo commented 12 years ago

I agree with Nick's comment. cURL detect username, password and port automatically from the dataURL. Seems redundant.