includes.js exists as Includes.js, but is requested in lower-case

yodeski / mvc-mini-profiler

Automatically exported from code.google.com/p/mvc-mini-profiler

0 stars 0 forks source link

includes.js exists as Includes.js, but is requested in lower-case #141

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

In Stackexchange.Profiling/UI there is a file called Includes.js, with an 
uppercase I, however the browser-side JS calls it as includes.js, which makes 
things break on non-windows OSes due to case-sensitivity. Maybe all of the 
files in there could be renamed to lower-case versions along with their 
respective load calls?

Original issue reported on code.google.com by xenofur@gmail.com on 2 Mar 2012 at 8:20

GoogleCodeExporter commented 9 years ago

Can be closed: https://github.com/SamSaffron/MiniProfiler/pull/18

Original comment by gro...@gmail.com on 21 Mar 2012 at 9:02

Added labels: ****
Removed labels: ****

GoogleCodeExporter commented 9 years ago

I'm sorry, this cannot be closed yet. The merge request is a bandaid fix, where 
the real solution is to rename the files, since they are still addressed 
improperly:

https://github.com/SamSaffron/MiniProfiler/blob/master/StackExchange.Profiling/U
I/MiniProfilerHandler.cs#L40
https://github.com/SamSaffron/MiniProfiler/blob/master/StackExchange.Profiling/U
I/MiniProfilerHandler.cs#L258

This is specifically an issue for me because i am working on a Perl port for 
this.

Original comment by walde.ch...@gmail.com on 21 Mar 2012 at 9:23

Added labels: ****
Removed labels: ****

GoogleCodeExporter commented 9 years ago

fixed properly now

Original comment by sam.saff...@gmail.com on 3 Apr 2012 at 4:22

Changed state: Fixed
Added labels: ****
Removed labels: ****

GoogleCodeExporter commented 9 years ago

Cheers, thanks. :)

Original comment by walde.ch...@gmail.com on 3 Apr 2012 at 8:36

Added labels: ****
Removed labels: ****