yoep / popcorn-fx

Popcorn FX is a multi-platform torrent streaming client that includes an integrated media player with support for embedded devices such as the Raspberry PI.
GNU General Public License v3.0
9 stars 1 forks source link

Bugfix/#232 subtitle not activating #233

Closed yoep closed 8 months ago

codecov[bot] commented 8 months ago

Codecov Report

Attention: 306 lines in your changes are missing coverage. Please review.

Comparison is base (ad495fd) 74.04% compared to head (fda86c7) 74.63%.

Files Patch % Lines
popcorn-fx-core/src/core/playlists/playlist.rs 0.00% 66 Missing :warning:
...oep/popcorn/backend/player/PlayRequestWrapper.java 0.00% 21 Missing :warning:
popcorn-fx/src/ffi/torrents.rs 64.81% 19 Missing :warning:
...pcorn/backend/subtitles/model/SubtitleInfoSet.java 67.39% 15 Missing :warning:
popcorn-fx/src/ffi/subtitles.rs 73.68% 15 Missing :warning:
popcorn-fx/src/ffi/loader.rs 0.00% 14 Missing :warning:
...p/popcorn/backend/torrent/TorrentStreamEventC.java 65.71% 12 Missing :warning:
.../popcorn/backend/subtitles/model/SubtitleInfo.java 0.00% 10 Missing :warning:
popcorn-fx-core/src/core/players/manager.rs 71.42% 10 Missing :warning:
...yoep/popcorn/backend/lib/WriteOnlyStringArray.java 0.00% 9 Missing :warning:
... and 31 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #233 +/- ## ============================================ + Coverage 74.04% 74.63% +0.59% - Complexity 1775 1788 +13 ============================================ Files 557 556 -1 Lines 37173 37874 +701 Branches 477 472 -5 ============================================ + Hits 27523 28269 +746 + Misses 9406 9357 -49 - Partials 244 248 +4 ``` | [Flag](https://app.codecov.io/gh/yoep/popcorn-fx/pull/233/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/yoep/popcorn-fx/pull/233/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `74.63% <75.77%> (+0.59%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.