search

yogakurniawan / vue-tel-input-vuetify

International Telephone Input with Vuetify.
https://yogakurniawan.github.io/vue-tel-input-vuetify/
MIT License
96 stars 57 forks source link

Countries with the same country code do not both show up as options - only one does #4

Closed davidstackio closed 3 years ago

davidstackio commented 4 years ago

Current behavior

The dropdown menu does not let countries with the same code (e.g. Canada and United States, Russia and Kazakhstan) show up at the same time.

Expected behavior

Both countries with the same code should show up on the list at the same time. Even though they both have the "+1" country code as this may be confusing for users in cases where IP address detection is inaccurate.

Versions

v1.2.8

Libraries:

Environment:

Additional context

This can be reproduced if in the US or Canada by setting the defaultCountry to not one of those (e.g. China: "CN").

MaksymMedved commented 4 years ago

The same situation with some other countries having the same country code (e.g., Russia and Kazakhstan).

miguelcabreja90 commented 3 years ago

Some solution for the missing countries given the same code in the select list for example Dominican Republic, Puerto Rico

brunosmm commented 3 years ago

The fix is change on the v-select component to use the "iso2" in the item-value.

@yogakurniawan I will send a pull request for this fix.

yogakurniawan commented 3 years ago

hi @brunosmm thank you for submitting the PR, i will check very soon

yogakurniawan commented 3 years ago

hi @brunosmm I have merged your PR. it's available on version v1.2.16 Can you help check if it has no issues on your side ? Thank you!

brunosmm commented 3 years ago

@yogakurniawan,

Seems all good, the fix worked!

davidstackio commented 3 years ago

Works for me too! Thanks!

miguelcabreja90 commented 3 years ago

Works Tks you