search

yogeshpaliyal / KeyPass

KeyPass: Open Source Project & An Offline Password Manager. Store, manage, and take control securely.
https://github.yogeshpaliyal.com/KeyPass/
MIT License
565 stars 72 forks source link

App resets on orientation change #992

Open nicolarevelant opened 2 months ago

nicolarevelant commented 2 months ago

Problem: when I perform this sequence of events the app resets:

  1. Enter the password
  2. Touch confirm button
  3. Rotate the device twice

or (if it's the first time):

  1. Create new password
  2. Touch confirm button
  3. Re-enter your password
  4. Touch confirm button
  5. Rotate the device twice

Possible solution:

This problem could be due to the "org.reduxkotlin:redux-kotlin-compose-jvm" library because it uses remember instead of rememberSaveable to store the app state (e.g. KeyPassBottomBar.kt:27), remember() does not store data using the saved instance state mechanism, so please consider not using that library and use the official navigation library and rememberSaveable for app state.

Screenshots:

Version:

1.4.29 (1429) - not fixed in 1.4.30

github-actions[bot] commented 2 months ago

Thanks for submitting your first issue, We appreciate your input and will review it soon.

yogeshpaliyal commented 2 months ago

Thank you for raising this issue, would you like to work on this issue?