search

yogiben / meteor-admin

A complete admin dashboard solution
https://atmospherejs.com/yogiben/admin
GNU General Public License v3.0
827 stars 261 forks source link

Compatibility with Meteor 1.2? #277

Closed ndarilek closed 8 years ago

ndarilek commented 8 years ago

Looks like various dependencies make it impossible to run this on Meteor 1.2. In particular, less and at least one additional package appear to require upgrades.

Any plans to make this run under 1.2? I can't upgrade any projects using this package because of its dependency constraints.

Thanks.

TimoRuetten commented 8 years ago

+1

pozylon commented 8 years ago

+1

ghost commented 8 years ago

+1

znat commented 8 years ago

+2

CaptainN commented 8 years ago

I have a pull request up for this. #276

For now you can download either a fork, or just a unzip an archive of this repo (or mine) and place it in your packages folder. Then make sure the LESS reference is updated to include the new required version number: less@1.0.0 || 2.5.0. Update: I changed the less dep so that it works for old versions of meteor too.

derdaumen commented 8 years ago

+1

macrozone commented 8 years ago

it is now merged and seems to work with meteor 1.2. Close?

CaptainN commented 8 years ago

There is actually a second issue. The less patch gets the package to install, but the data tables in the collection list pages are not working correctly in meteor 1.2 if the collection has any records.

thomasspiesser commented 8 years ago

is it the same as #280 ? can anyone still use this package with 1.2?

CaptainN commented 8 years ago

The issue I mentioned above about the data tables is the same as #280. The same issue was fixed in flow-db-admin - maybe someone could figure out what fixed it there, and apply the same fix here?

cagrigunal commented 8 years ago

+1

MartinBucko commented 8 years ago

+1

CaptainN commented 8 years ago

Please clone my repo to your local packages directory and see if my fix for the collection views works for you: https://github.com/CaptainN/meteor-admin/

Maay commented 8 years ago

@CaptainN thank you!

CaptainN commented 8 years ago

I redid my fork (because I screwed it up - still new to fork and PR workflow). The new PR #289 has the same fix and also a fix for the Users table.

CaptainN commented 8 years ago

Oh, it looks like my original PR #284 has the fix too. I think I'm starting to understand how the PR system works. :-)