yogstation13 / Yogstation

Discord: https://discord.gg/yogs13 Forums: https://forums.yogstation.net
GNU Affero General Public License v3.0
128 stars 447 forks source link

Bigass morgue glowup #22237

Open AMyriad opened 5 days ago

AMyriad commented 5 days ago

Document the changes in your pull request

Hi hello hi I ported some cool stuff for morgues and bodybags, namely The cool tray animation in https://github.com/tgstation/tgstation/pull/83127 by Melbert And lots of refactoring done in https://github.com/tgstation/tgstation/pull/75065 by JohnFulpWillard

So basically:

Why is this good for the game?

Moar content is bery good

Testing

https://github.com/yogstation13/Yogstation/assets/143908044/6ee471b3-ffc9-45c8-9a88-a49e4b4c6db3

image image image

Changelog

:cl: AMyriad, Melbert, JohnFulpWillard rscadd: Opening/closing morgues now have a tray sliding animation tweak: Hiding in morgues will now obscure your vision a bit rscadd: Added TGUI input menu to tagging bodybags rscadd: Tagging bodybags with a pen now applies the tag to the morgue box it's currently in rscadd: You can now craft morgue/cremator trays in the crafting menu to replace any broken ones rscdel: Removed occasionally hearing the howls of the damned while standing in the morgue area experimental: Refactored some morgue and bodybag code, you make bug report if see problem agagag /:cl:

wonderinghost commented 5 days ago

now if only they were craftable and deconstructable

AMyriad commented 5 days ago

realized I broke something guh

Firewolf34 commented 4 days ago

I wonder if breaking the morgue trays is a strat for the revenant to expose bodies?

Tagging bodybags with a pen now applies the tag to the morgue box it's currently in

Maybe we'll see the tags get more use now.

Also I might be wrong but you may have removed the last reference to spooky ambience. If that is the case, why not just remove the first two items from the list (I think that's what you're referring to as "screams of the damned" lol) instead of entirely removing the AMBIENCE_SPOOKY key from the area:

https://github.com/yogstation13/Yogstation/blob/master/code%2F_globalvars%2Flists%2Fambience.dm#L82

ambimo1.ogg ambimo2.ogg

(also could be wrong again but the fingerprint might've been lost on close)