Ok so toe stubbing used a really shitty system where every species that COULD stub their toes needed to have a proc "registered" to it every single time.
Like
/datum/species/lizard/has_toes()
return TRUE
for example, and this needed to be added to each individual species. Only a few had this up until now, which might be why I - and probably some other people - had no idea stubbing your toe was an actual mechanic.
Anyways, the downside to this PR is removing the cool realistic aspects of stubbing your toe added by none other than AutisticFroggy way back in #9340. My take is the code from Bee is a lot less schizophrenic and accomplishes basically the same thing, even if it doesn't do cool stuff like make blind people have a 20% chance of stubbing their toe instead of 0.033% or something like that. Like the realism is cool but I'm not going to try and make all those specifics work with this simplistic stuff.
Do go ahead if you have advice on how to keep it though.
Testing
Got my toe to stub off-camera walking into tables without shoes. Here I smited myself to stub my toe once, then smited myself with the second punishment: a curse that makes you stub your toe every time you walk into a table.
:cl: AMyriad, Ivniinvi, ike709
experimental: Refactored stubbing your toe on tables, now every race can suffer equally if they're barefooted :)
rscadd: Admins can now force people to stub their toes...or worse...
/:cl:
cuackles
commented
2 days ago
Document the changes in your pull request
Port of these lovely PRs: Most of the toe stubbing code in https://github.com/BeeStation/BeeStation-Hornet/pull/1940 and https://github.com/BeeStation/BeeStation-Hornet/pull/1998 by ike709 Letting admins punish people with it in https://github.com/BeeStation/BeeStation-Hornet/pull/5347 by Ivniinvi
Why is this good for the game?
Ok so toe stubbing used a really shitty system where every species that COULD stub their toes needed to have a proc "registered" to it every single time. Like
for example, and this needed to be added to each individual species. Only a few had this up until now, which might be why I - and probably some other people - had no idea stubbing your toe was an actual mechanic.
Anyways, the downside to this PR is removing the cool realistic aspects of stubbing your toe added by none other than AutisticFroggy way back in #9340. My take is the code from Bee is a lot less schizophrenic and accomplishes basically the same thing, even if it doesn't do cool stuff like make blind people have a 20% chance of stubbing their toe instead of 0.033% or something like that. Like the realism is cool but I'm not going to try and make all those specifics work with this simplistic stuff.
Do go ahead if you have advice on how to keep it though.
Testing
Got my toe to stub off-camera walking into tables without shoes. Here I smited myself to stub my toe once, then smited myself with the second punishment: a curse that makes you stub your toe every time you walk into a table.
https://github.com/yogstation13/Yogstation/assets/143908044/d11a2553-42fd-4365-8b0e-06f90794e178
Changelog
:cl: AMyriad, Ivniinvi, ike709 experimental: Refactored stubbing your toe on tables, now every race can suffer equally if they're barefooted :) rscadd: Admins can now force people to stub their toes...or worse... /:cl: