search

yogstation13 / yogstation-classic

Yogstation13's classic code source.
http://www.yogstation.net
GNU Affero General Public License v3.0
10 stars 37 forks source link

Softcore TGUI and stockmarket port #1196

Closed Super3222 closed 8 years ago

Super3222 commented 8 years ago

Intent of your Pull Request

Refer to issue #1111.

Changelog

:cl:Super3222 rscadd: Special thanks to Neersighted for designing and locating bugs within the tgui port rscadd: Special thanks to goofball for translating the stockmarket system from goon into /tg/ code. /:cl:

Super3222 commented 8 years ago

If you haven't noticed now, all of my commit messages are titles of GoT books with a word changed to 'conflicts'.

AdamElTablawy commented 8 years ago

explaining the joke

after you're done coding this, kill yourself

AsV9 commented 8 years ago

Travis passed.

could it be :o

oisin100 commented 8 years ago

Looks good, As far as i can tell atleast(Obviously i haven't read it all yet.) If some of the other @yogstation13/coders @yogstation13/senior-coders could take a look it would save me a lot of work.

I could really do with that JSON parser for yogstats

Super3222 commented 8 years ago

Just want to make a reminder, that the only tgui feature that'll be playable in game will be the cargo system. Everything else will still be using nanoui.

Also, the supply shuttle approximately takes 5 seconds to arrive / leave. I feel like this should be changed to something like 30 seconds.

EDIT: Also I'd like to throw in that the motion is a little choppy, but that might just be on my end of the stick with the hosting. I'd like for that to get tested.

AdamElTablawy commented 8 years ago

No its fine super

oisin100 commented 8 years ago

I created some conflicts with the map, Enjoy!