search

yogstation13 / yogstation-classic

Yogstation13's classic code source.
http://www.yogstation.net
GNU Affero General Public License v3.0
10 stars 37 forks source link

Changes nukeops war to be a vote #1262

Closed Cruix closed 8 years ago

Cruix commented 8 years ago

Intent of your Pull Request

Changes nuke ops declaring war to be a vote requiring 3/5 in favor.

Changelog

:cl: tweak: All nuke ops start with an item that allows them to vote for war. War will be declared if 3 out of five nukeops vote yes. /:cl:

So when your leader is afk for four and a half minutes and everyone decides to not do war, he doesn't come back and immediately press the war button.

Cruix commented 8 years ago

Hold on I am fixing it. Jesus I am tired I should not have pushed this yet.

Cruix commented 8 years ago

Alright I will sleep and see if I can find anything wrong with it tomorrow.

utahclock commented 8 years ago

I thought we werent merging anything to yog due to rebase?

Super3222 commented 8 years ago

Syndicate

Democracy

Okay.

X-TheDark commented 8 years ago

I think this isn't bad per se. Leader should obviously be the one calling the shots, but giving him a roundchanging decision to do on his own without teams input is not good, but having the team decide instead of the leader (especially, since the Leader is the one who receives the new uplink with the extra crystals) would also cause a lot of problems.

I'm not sure how the admins would react to the team "overthrowing" the leader and taking his extra uplink you get from war forcibly just because they all voted on it and the leader didn't.

oisin100 commented 8 years ago

Me likey.