search

yogthos / json-html

Provide EDN/JSON and get a DOM node with a human representation of the data
MIT License
162 stars 15 forks source link

sorted-map is chocking when keywords aren't of the same type #5

Closed Frozenlock closed 9 years ago

Frozenlock commented 9 years ago

See https://github.com/yogthos/json-html/blob/master/src/json_html/core.clj#L55

I would propose to go back to the previous (map-indexed vector this)

One could also stringify all keys, but the :a and "a" would collide and one of the two fields would be lost.

yogthos commented 9 years ago

Doing (str :foo) will preserve the :, so perhaps that would be a better way to go. I do like the predictable result of the sorted-map.

Frozenlock commented 9 years ago

Sounds good.

You push or I do?

yogthos commented 9 years ago

just made the fix :)

yogthos commented 9 years ago

I can push to clojars when I get home

Frozenlock commented 9 years ago

:heart:

yogthos commented 9 years ago

ok it's up on clojars, let me know if everything looks good :)

Frozenlock commented 9 years ago

Yup, everything works!