search

yogthos / lein-asset-minifier

Leiningen plugin for CSS/Js asset minifcation
Eclipse Public License 1.0
41 stars 7 forks source link

ignore Google Closure warnings #1

Open stephanos opened 9 years ago

stephanos commented 9 years ago

Hey there,

when I run 'lein minify-assets' I have a few warnings from Google Closure:

JSC_BAD_JSDOC_ANNOTATION. Parse error. illegal use of unknown JSDoc tag "internal"; ignoring it at resources/js/react.js line 4403 : 5
JSC_BAD_JSDOC_ANNOTATION. Parse error. illegal use of unknown JSDoc tag "providesModule"; ignoring it at resources/js/react.js line 4618 : 5
JSC_INVALID_PARAM. Parse error. invalid param name "forEachFunc." at resources/js/react.js line 4658 : 31
JSC_INVALID_PARAM. Parse error. invalid param name "mapFunction." at resources/js/react.js line 4718 : 31
JSC_BAD_JSDOC_ANNOTATION. Parse error. illegal use of unknown JSDoc tag "providesModule"; ignoring it at resources/js/react.js line 4766 : 5

Do you think you could add an option to silence those?

yogthos commented 9 years ago

That should be doable, I'd have to take a look what the option is.

stephanos commented 9 years ago

Great! This old leiningen 1.x plugin might be a good inspiration: https://github.com/maravillas/lein-js :)

yogthos commented 9 years ago

Thanks, I'll take a look hopefully the Google Closure API hasn't changed too much in the meantime. :)