Add yaml and edn metadata processing; solves #153

yogthos / markdown-clj

Markdown parser in Clojure

Eclipse Public License 1.0

540 stars 120 forks source link

Add yaml and edn metadata processing; solves #153 #154

Closed metasoarous closed 5 years ago

metasoarous commented 5 years ago

Complete with passing tests (solves #153).

Thanks for reviewing!

yogthos commented 5 years ago

Thanks that looks great. Might be worth adding a note about different formats in the readme as well.

yogthos commented 5 years ago

Unfortunately, it looks like io.forward/yaml is clj only. We'll need a solution that works for cljc or yaml parsing could be restricted to clj mode.

yogthos commented 5 years ago

I ended up throwing unsupported error for cljs version, and 1.10.0 is up on Clojars with the new features.

metasoarous commented 5 years ago

Oh, bummer. I didn't realize that. Next time I'll make sure to run the cljs tests. In any case, thanks for the clj fix, and the release!

yogthos commented 5 years ago

No worries, and thanks for the PR. :)