search

yogthos / markdown-clj

Markdown parser in Clojure
Eclipse Public License 1.0
540 stars 120 forks source link

parsing now identical for clj and cljs #203

Closed habruening closed 3 months ago

habruening commented 3 months ago

I did a few more changes to the code. I try to make core.clj and core.cljs more similar to each others.

The diff is hard to read, so I explain what I did. First I removed everything which is IO related from the parsing functions. They now accept a (lazy) list of strings. The code that delivers this list of strings have actually not changed, only moved. And after having done this, the two parsing functions become identical for clj and cljs. So I moved them into the cljc area.

I could also try to make init-transformer common.

I don't know if all this is worth the effort. I actually have no concrete goal. I do this just for fun in order to get more experienced with Clojure. So you can decide if you also like this PR.

yogthos commented 3 months ago

I appreciate the effort even if it is just for fun. Consolidating the code is a plus, and keeping platform specific details at the edges is cleaner. If you want to update init-transformer as well, that sounds good to me. Shouldn't be too hard to do now that you've got this refactor going.