search

yogthos / memory-hole

Memory Hole is a support issue organizer application
MIT License
259 stars 25 forks source link

Bug: Issues sometimes appear unfiltered even though a tag is selected #47

Closed lacarmen closed 4 years ago

lacarmen commented 4 years ago

Steps to reproduce:

  1. Select a tag
  2. Click on an issue
  3. Navigate back to the home page by clicking "Issues" in the top left corner

You will see that the tag you selected previously is still selected but the list of issues is no longer filtered. Issue filtering is triggered by a url change to /issues/tag-name (ie. it happens on the backend) so I suggest we filter in the re-frame subscription for :visible-issues to correct this without having to do weird routing things.

lacarmen commented 4 years ago

Partially fixed in #48... Tag is applied when navigating back to the home page but the issues returned from the server are for "Recent" so you may not end up seeing all of the issues for that tag. There is no way to get around this without updating the queries.

lacarmen commented 4 years ago

Since there's no way to get around this without updating a lot of queries/logic, I updated the app to select the "Recent" tag anytime you navigate to /