yogthos / migratus

MIGRATE ALL THE THINGS!
641 stars 95 forks source link

List migration logs #251

Closed sandre1 closed 11 months ago

sandre1 commented 11 months ago
yogthos commented 11 months ago

Overall looks good to me, would just swap out cheshire for clojure.data.json

yogthos commented 11 months ago

@ieugen thanks for doing a more thorough review, and I'm good to merge if everything looks good to you

ieugen commented 11 months ago

@yogthos : I think it's ready to merge. I am not particularly fond of terminal output with logging. It would be nice to improve that, but I think the code is an improvement to migratus and a step forward.

yogthos commented 11 months ago

Agreed, we could do a separate PR to make that nicer. And just released 1.5.3 to Clojars with the update @sandre1 thanks for spearheading the effort on this. :)