Fix spec problem for next.jdbc.sql/insert! and next.jdbc.sql/delete!

yogthos / migratus

MIGRATE ALL THE THINGS!

641 stars 95 forks source link

Fix spec problem for next.jdbc.sql/insert! and next.jdbc.sql/delete! #262

Closed kolstae closed 4 months ago

kolstae commented 4 months ago

When in dev mode, where I run clojure.spec.test.alpha/instrument, migrations would not run saying Migration reserved by another instance. Ignoring. It turns out there's a spec problem calling insert! and delete! with table-name as a string. Although a string works perfectly if you just don't spec check it.

Note And don't silently ignore mark-reserved errors

kolstae commented 4 months ago

Sorry I was unable to run the tests :disappointed: For testing without docker but with postgresql there's pg-embedded-clj (which was how I discovered this bug)

yogthos commented 4 months ago

Thanks for the fix, I've just pushed out 1.5.6 with the changes.