search

yogthos / migratus

MIGRATE ALL THE THINGS!
647 stars 95 forks source link

Migratus CLI requires `clojure.data.json` but the jar does not specify the dependency #272

Closed p-himik closed 6 hours ago

p-himik commented 7 hours ago

I see that deps.edn lists clojure.data.json as a dependency, but project.clj doesn't. I suspect that the JAR is generated from project.clj hence the missing dependency.

yogthos commented 6 hours ago

Yup, missed adding it in project.clj, just pushed out 1.6.2 with the dependency added.

p-himik commented 6 hours ago

For my own understanding - is project.clj there only because of historical reasons (and consequent current usage)? Or are there things that aren't easily achievable with deps.edn and build.clj?

yogthos commented 5 hours ago

Yeah, project.clj is how it was set up historically, and I still use it to package the jar when doing releases. It could definitely be done using deps.edn and build.clj going forward. I just haven't got around to switching that around.