search

yohamta / donburi

Just another ECS library for Go/Ebitengine
https://pkg.go.dev/github.com/yohamta/donburi
Other
232 stars 21 forks source link

Add MustFirstEntity #88

Closed m110 closed 1 year ago

m110 commented 1 year ago

Note: shouldn't these methods use Entry instead of Entity? Like FirstEntry? Since it returns an entry. 🤔

yohamta commented 1 year ago

@m110 Thank you very much for adding the helpful function 😄 Sorry for the delay in responding to your pull request. I've been overwhelmed with notifications on GitHub and I inadvertently missed your request for a few days.

yohamta commented 1 year ago

Yeah, I agree. I think the name should be using Entry instead of Entity. I think we can add new methods with proper names and deprecate the old method name 🙂

On second thought, one concern is that since ECS stands for Entity, users might expect it to have a FirstEntity() method as well, so it might be a bit confusing. I think naming it just First() might be good 🤔