search

yohang / CalendR

The missing PHP 5.3+ calendar management library.
http:/yohan.giarel.li/CalendR
MIT License
465 stars 65 forks source link

Allow Symfony3 #43

Closed garak closed 8 years ago

garak commented 8 years ago

I also squashed commits. Can your merge please?

robations commented 8 years ago

Works for me. (Fixes #44)

garak commented 8 years ago

Any news?

yohang commented 8 years ago

Seems fine, thanks.

garak commented 8 years ago

What about a new tag?

yohang commented 8 years ago

Master branch will be tagged 2.0, as there is some BC breaks, and 2.0 is not ready ATM.

garak commented 8 years ago

What about 1.1.2 tag?

yohang commented 8 years ago

Yep. I'll cherry-pick this commit into 1.1.

garak commented 8 years ago

Great! Thank you

yohang commented 8 years ago

Hum. Badly, that's not possible. 1.1 version is tied to symfony >= 2.3, wich is incompatible with the new OptionsResolver.

The only way to made 1.1 compatible with Symfony 3 is to bump the symfony requirement to >= 2.7, and... That's a BC break.

I'll release 2.0, but documentation won't be in sync.