search

yohang / Finite

A Simple PHP Finite State Machine
http://yohan.giarel.li/Finite
MIT License
1.31k stars 188 forks source link

Event Params #72

Closed Padam87 closed 8 years ago

Padam87 commented 9 years ago

It would be useful to be able to pass params to transition events. See the doc for more details

Q A
Test Pass? y
License MIT
yohang commented 9 years ago

Love this idea, but this could be nice to be able to define parameters constraints (via option-resolver ?) into the configuration.

Padam87 commented 9 years ago

@yohang Good to go

Padam87 commented 9 years ago

@yohang ping

selossevianney commented 9 years ago

This is what I need and I'm not the only one. Why did Yohang never merged this PR? Go ahead @yohang You'll do the right thing :+1:

Padam87 commented 9 years ago

I was thinking about creating a fork for this lib, and start implementing new stuff there. @yohang doesn't seem to be working on this anymore.

selossevianney commented 9 years ago

Too bad. Stop thinking, do it :)

yohang commented 8 years ago

I'll probably merge your PR today, but I’m thinking to a more flexible way to define the OptionsResolver.

Here is what I'd prefer for the resolver :

Thanks for the good work !

Padam87 commented 8 years ago

Sorry, no more changes from my part... It's been more than a year, if I change this again it will be another year. Merge it, and the yaml config should be done separately.

yohang commented 8 years ago

I know, and agree, I'll do the work, I can't ask you to do it after 1 year !

yohang commented 8 years ago

Closing as I continue your work in #97.

Thanks for making it and sorry for not being available :(