search

yohang / Finite

A Simple PHP Finite State Machine
http://yohan.giarel.li/Finite
MIT License
1.31k stars 188 forks source link

fix for symfony/options-resolver 2.6+ #85

Closed keiosweb closed 8 years ago

keiosweb commented 9 years ago

We had an issue with Finite installing along symfony/options-resolver 2.6+ which caused E_DEPRECATED errors due to new syntax of setAllowedTypes method. This little fix removes the error, it is however optional, because you have 2.4.4 in your composer.lock file (which was somehow ignored in our system). You could add this to prevent problems with update to 2.6+/3.0 of options-resolver or simply ignore this, as manual specification of "symfony/options-resolver": "2.4.4" in our composer.json seemed to do the trick too.

Cheers.

Related to issue #84.

gabrieltong commented 9 years ago

@keiosweb It's very useful, why not merge into maste ?

hacfi commented 9 years ago

LGTM

benatespina commented 9 years ago

@keiosweb Can you tag this PR as new release in your forked repository? In this way we can include in the composer.json with vcs statement. ;) Thanks!

hacfi commented 9 years ago

@benatespina dev-master as version should work until the commit is tagged.

keiosweb commented 9 years ago

Not going to tag release on fork, this should be commited to new release from author. What's up with @yohang ?

phillipsnick commented 9 years ago

Don't think this repository is maintained anymore by the looks of things?

nicodmf commented 9 years ago

@yohang : Have you informations about mergin process ? This library is very usefull and well writed

keiosweb commented 9 years ago

Seems like @yohang is missing, anyone knows what happened to him? Is someone willing to fork repo and provide maintenance?

hacfi commented 9 years ago

@keiosweb He seems to be doing fine: https://twitter.com/rouks ..probably just very busy!

tortuetorche commented 9 years ago

Hi @yohang,

Can you merge this pull request, please? It'll be really useful for every Finite users who use a recent version of Symfony or Laravel.

If you want to keep backward compatibilities for users who have symfony/options-resolver < 2.6, maybe you can create a new branch to merge this pull request or just bump version to 1.1.0 with this constraint in composer.json:

"symfony/options-resolver": "~2.6",

Have a good day, Tortue Torche

yohang commented 8 years ago

Thanks for your PR, but I merged #91, which includes the Symfony version bump.