search

yohannesdagnachew / Catalog-of-my-things

1 stars 2 forks source link

Add blueprint for objects of class Book #23

Closed Felix45 closed 2 years ago

Felix45 commented 2 years ago

Changes in this pull request

In this pull request I implemented the following

  • Created class Book in a book.rb file.
  • Implemented all Book class properties visible in the UML diagram in the constructor method.
  • redefined method can_be_archived?() in the Book class
yohannesdagnachew commented 2 years ago

Hi @Felix45

APPROVED 🟢

Highlights

✔️ Descriptive PR ✔️ Passing linters ✔️ Good branch name

Great implementation of all the requirements in this milestone. 👏

You have done an amazing job 👍

Your project is complete! There is nothing else to say other than... it's time to merge it. :shipit:

Congratulations! 🎉

CHEERS AND HAPPY CODING!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Felix45 commented 2 years ago

Hi @yohannesdagnachew thanks for the review :+1: