search

yohanshin / WHAM

MIT License
633 stars 70 forks source link

The meaning of updating intrinsics #94

Open xjwxjw opened 3 months ago

xjwxjw commented 3 months ago

Hi, I noticed that this line: https://github.com/yohanshin/WHAM/blob/2b54f7797391c94876848b905ed875b154c4a295/lib/vis/renderer.py#L165 updated the intrinsics and the image size. What's it for? Is this necessary? What if I directly use the original intrinsic param? Thank you very much.

yohanshin commented 2 months ago

This is to accelerate the rendering process. Let's say we have 1920 x 1080 image and we want to render the mesh at the center (rendered mesh size is approximately 500 pixels). Instead of using the full image, we can actually get a rough bbox where the mesh will be projected, then we can re-model the renderer to only care of that smaller region.