search

yohcop / openid-go

OpenID consumer implementation in Go - golang
Other
83 stars 40 forks source link

Provide TimedDiscoveryCache #46

Closed strk closed 7 years ago

strk commented 7 years ago

Fixes #45

strk commented 7 years ago

I'd fix gofmt test if I knew how to install gofmt...

xStrom commented 7 years ago

gofmt is included with the default Go installation and is located in the same directory as go.

You'll want to run something like gofmt -l -s -w .\ while being in the source directory.

yohcop commented 7 years ago

You can also just look at the couple of lines of diffs in the failed test, and re-adjust those. I think there was 3 lines only. But anyway, I don't think this should be submitted as is, in this location. See discussion on the bug.

yohcop commented 7 years ago

So after discussion on #45 I guess we are not going to merge this. But thanks anyway :) Like I said I started a short list of such libraries. So if you ever put your code in a separate library, feel free to send a pull request adding a link in the README file! Thanks!