search

yohcop / openid-go

OpenID consumer implementation in Go - golang
Other
83 stars 40 forks source link

Code cleanup #9

Closed ghost closed 9 years ago

yohcop commented 9 years ago

Hi, Thanks for the pull request. I am fine with most of them, only the package rearranging bothers me because of the _example directory. Is that a standard practice to use "_example"? do you have other example repos that uses this format? Thanks!

ghost commented 9 years ago

Is that a standard practice to use "_example"?

I'm not sure if there's been any official opinion made by the Go developers, but I have seen projects use this format. For example: go-sqlite3 and termbox-go. I think the idea of the underscore prefix is to imply that the path should not be imported by another package.

But honestly, it doesn't matter to me one way or the other. Let me know which one you prefer and I can make any necessary changes.

yohcop commented 9 years ago

ok well, let's go with that, and if some "standard" emerges later, we can always switch to that....