search

yoheimuta / go-protoparser

Yet another Go package which parses a Protocol Buffer file (proto2+proto3)
MIT License
179 stars 20 forks source link

allow ident start with underscore #29

Closed wangfenjin closed 5 years ago

wangfenjin commented 5 years ago

Change-Id: I4756755c0f684e51a5dffa36a458276ee4e60611

I know it's insane, but other parser allow ident start with underscore...

There is even a test case for this: https://github.com/golang/protobuf/blob/master/protoc-gen-go/generator/name_test.go#L51

yoheimuta commented 5 years ago

Thank you for your contribution. LGTM!