search

yoheimuta / go-protoparser

Yet another Go package which parses a Protocol Buffer file (proto2+proto3)
MIT License
166 stars 20 forks source link

Update gomod file to point to /v4, as defined by gomod standard. #46

Closed PaulSonOfLars closed 4 years ago

PaulSonOfLars commented 4 years ago

To allow for proper semver versioning, the package path should terminate wiht /v4, as mentioned in https://github.com/golang/go/wiki/Modules#how-are-v2-modules-treated-in-a-build-if-modules-support-is-not-enabled-how-does-minimal-module-compatibility-work-in-197-1103-and-111.

The reason for v4 and not v3 is that this is a gomod change which changes importpaths, and as such can be considered a breaking change.

This will allow users to point to the protoparser through github.com/yoheimuta/go-protoparser v4.0.0 in their gomod file, instead of the current github.com/yoheimuta/go-protoparser v1.3.1-0.20191127232502-7d443993ac15, which is gross, requires go get link@hash, and more importantly, is not the default. (default is github.com/yoheimuta/go-protoparser v3.4.0+incompatible, an older version)

yoheimuta commented 4 years ago

[memo] This way is following the Major branch approach.