search

yoheimuta / go-protoparser

Yet another Go package which parses a Protocol Buffer file (proto2+proto3)
MIT License
166 stars 20 forks source link

Installation instructions in readme is invalid #48

Closed samuelfekete closed 4 years ago

samuelfekete commented 4 years ago

Readme says to do: go get github.com/yoheimuta/go-protoparser/v4 But this returns an error:

package github.com/yoheimuta/go-protoparser/v4: cannot find package "github.com/yoheimuta/go-protoparser/v4" in any of...
samuelfekete commented 4 years ago

Look like for Go version 1.13 it needs to be: GO111MODULE=on go get github.com/yoheimuta/go-protoparser/v4

yoheimuta commented 4 years ago

@samuelfekete Good catch, thanks! The GO111MODULE still defaults to auto for version 1.13.

The GO111MODULE environment variable continues to default to auto, but the auto setting now activates the module-aware mode of the go command whenever the current working directory contains, or is below a directory containing, a go.mod file — even if the current directory is within GOPATH/src. This change simplifies the migration of existing code within GOPATH/src and the ongoing maintenance of module-aware packages alongside non-module-aware importers.

I'll fix it in a moment.

yoheimuta commented 4 years ago

I fixed it.

samuelfekete commented 4 years ago

Thanks @yoheimuta