yoheimuta / protolint

A pluggable linter and fixer to enforce Protocol Buffer style and conventions.
MIT License
556 stars 51 forks source link

FILE_NAMES_LOWER_SNAKE_CASE: an issue with dot separated filenames #340

Closed AlexCannonball closed 11 months ago

AlexCannonball commented 1 year ago

Hello,

The linter suggests wrong fix for dot separated filenames. For example, a file dot.separated.proto receives the following error message: "File name \"dot.separated.proto\" should be lower_snake_case.proto like \"dot.separated.proto\"."

As I understand, dot separated names doesn't follow the rule/guidelines, so it should suggest setting to "dot_separated.proto".

Thank you.

yoheimuta commented 1 year ago

@AlexCannonball Thank you for creating this issue! https://github.com/yoheimuta/protolint/releases/tag/v0.45.2 should fix it.

AlexCannonball commented 11 months ago

@yoheimuta Thank you, I confirm it's not reproducing after the fix.