search

yoheimuta / protolint

A pluggable linter and fixer to enforce Protocol Buffer style and conventions.
MIT License
555 stars 51 forks source link

Bug: Missing 'new' in https://github.com/yoheimuta/protolint/blob/master/bdist/js/install.mjs #426

Closed pekarasa closed 1 month ago

pekarasa commented 1 month ago

The keyword 'new' is missing in line 31 of the install.mjs file. The line should look like this: agent = new HttpProxyAgent(process.env.PROTOLINT_PROXY);

It would be even better if process.env.HTTP_PROXY or process.env.HTTPS_PROXY were used for Windows instead.

carstencodes commented 1 month ago

I'll take a look at that. But I am very busy at the moment, might take until the end of the week.

carstencodes commented 1 month ago

Hi @pekarasa,

can you take a look at #427, if it goes into the right direction.

pekarasa commented 1 month ago

Hello carsencodes, works fine, just downloaded and tested. Thank you very much!

yoheimuta commented 1 month ago

I just published the release with this fix: https://github.com/yoheimuta/protolint/releases/tag/v0.50.4. Thanks!