search

yoheimuta / protolint

A pluggable linter and fixer to enforce Protocol Buffer style and conventions.
MIT License
555 stars 51 forks source link

fix: Proxy Agent usage #427

Closed carstencodes closed 1 month ago

carstencodes commented 1 month ago

The proxy variable will be used correctly. The HTTPS_PROXY / HTTP_PROXY will be used, if PROTOLINT_PROXY is not set.

Evaluation takes place: if the remote url starts with https, HTTPS_PROXY will be used, otherwise HTTP_PROXY will be used. This interpretation is questionable, but makes sense in the first place.

Closes #426

pekarasa commented 1 month ago

Hello carsencodes, works fine, just downloaded and tested. Thank you very much!

carstencodes commented 1 month ago

Great. I just figured out, that this might be odd, if you don't want to use a proxy at all. So I would also add PROTOLINT_NO_PROXY ignoring all proxy settings tonight.

carstencodes commented 1 month ago

So, no proxy can be disabled in air-gapped scenarios.