Closed hsm207 closed 1 year ago
@Ryangr0 @francip how's this PR looking? We just need to prepare some docs so it would be great if you could review the code in the mean time.
Looks good for the most part. The only nitpick I have is the fallback logic. Here's what I'd like to see (but we can do as follow up)
With the current implementation, if Weaviate is turned on, but fails, it directly goes to Chroma. Not a big issue, as allegedly people that try to configure Weaviate don't care about Pinecone... :-)
- Check if Weaviate env variable there
- If Yes, check if Weaviate is installed and can be loaded
- If Yes, everything's peachy
- If Weaviate env variable not there or Weaviate not installed, check Pinecone (same algo as above)
- If Pinecone fails, use Chroma.
@francip I've refactored the fallback logic based on your feedback. All good?
Looks good. Let's merge it in... (It's still a draft rn, so I can't :-) )
Are we landing this or what? :-p
it will be ready to merge in a couple of days. @zainhas is making some final touches on the docs 😀
@francip we're done with the docs
Thanks! Merged.
Fixes #239