added the value of parameter into Exception message for easier debuging

yojimbo87 / ArangoDB-NET

C#/.NET/Mono driver for ArangoDB

MIT License

107 stars 66 forks source link

added the value of parameter into Exception message for easier debuging #56

Open dvdnhm opened 5 years ago

dvdnhm commented 5 years ago

System.Exception: Invalid Value: [val]

console version:

dvdnhm commented 5 years ago

added a fix for pulling byte[] from db

yojimbo87 commented 5 years ago

Hi, thanks a lot for the pull request! It seems that these changes affect mainly fastJSON external library. Would you be able to create some unit test cases which demonstrate the bug in the fastJSON library and rerun its test suite to find out whether there is not some regression?

dvdnhm commented 5 years ago

To be honest; I don't know how to write tests, at least not yet. I will try to do it but might take a while.

yojimbo87 commented 5 years ago

That's ok, take your time. My main concern here is that this change might break or affect the existing functionality of the driver. That's why I would rather like to have a test case which demonstrates the bug in fastJSON library. Once this is proven, pull request can be created in fastJSON repo, fixed there and then the library can be updated within the driver.