search

yokai-php / sonata-workflow

Integrate Symfony workflow component in Sonata Admin
MIT License
22 stars 12 forks source link

configureSideMenu() is deprecated and completely removed in Sonata-Admin 4.x #29

Closed danaki closed 3 years ago

danaki commented 3 years ago

Following up #28

danaki commented 3 years ago

Seems configureSideMenu() just renamed to configureTabMenu()? https://github.com/sonata-project/SonataAdminBundle/pull/5994

yann-eugone commented 3 years ago

Yes, I did start to rename last week but...

To be able to support 4.x, we will have to create new major version too, because there is some methods that changed signature too, and there is no way to be compatible with both versions :

Fatal error: Declaration of 
Yokai\SonataWorkflow\Admin\Extension\WorkflowExtension::configureRoutes(Sonata\AdminBundle\Admin\AdminInterface $admin, Sonata\AdminBundle\Route\RouteCollection $collection): void 
must be compatible with 
Sonata\AdminBundle\Admin\AbstractAdminExtension::configureRoutes(Sonata\AdminBundle\Admin\AdminInterface $admin, Sonata\AdminBundle\Route\RouteCollectionInterface $collection): void

This is why I didn't finished it yet.

danaki commented 3 years ago

Ok, just push everything you have so far into a 4.x-dev branch and I will help you with testing.

yann-eugone commented 3 years ago

Sure, just opened #30

yann-eugone commented 3 years ago

@danaki support for sonata 4.x was added in https://github.com/yokai-php/sonata-workflow/releases/tag/v0.6.0