search

yokawasa / azure-functions-python-samples

Azure Functions Python Sample Codes. NOTE: The project, hosted in a repository, is no longer actively maintained by its creators or contributors. There won't be any further updates, bug fixes, or support from the original developers in the project.
MIT License
392 stars 181 forks source link

Update documentation for Storage Connection String and add Azure Extension bundle #27

Closed lastcoolnameleft closed 5 years ago

lastcoolnameleft commented 5 years ago

I tried running through the documentation and the Blob Trigger didn't work until I performed the steps listed.

snobu commented 5 years ago

Thanks for catching this! @yokawasa, i believe this is needed (only locally) for all functions that use a blob trigger/input/output, right? Or any function that touches Azure Storage?

snobu commented 5 years ago

@lastcoolnameleft, the host.json in the root of the function app seems to have the bundles in already, which should take effect for all functions under that function app. Did you clone the repo or started from scratch and maybe missed that config file?

If the latter, i believe we should definitely mention why the bundle is in there and link to the host.json file for clarity. We should surface this in the root README. Maybe let's add a link to this page as well. Can you please make this change instead?

LATER EDIT: Looks like we do mention bundles here already - https://github.com/yokawasa/azure-functions-python-samples/blob/master/docs/quickstart-v2-python-functions.md#update-the-hostjson-file-to-use-extension-bundles

We could add a link to that section to all the READMEs for all the sample functions in here. Something more generic maybe, like Hey don't start here, go through the quickstart first to understand setup and dependencies for local development.

lastcoolnameleft commented 5 years ago

Closing this PR as I realized it was PEBKAC. (I ran func host start in the sub dir (e.g. blob-trigger-watermark-blob-out-binding) , which allows the function to start and creates a new host file. once I added the changes, then everything worked for me, but if I would have ran it in the correct directory, that would have fixed my root problem) Sorry for the inconvenience.

That said, I think the documentation suggestions you stated would be useful. Specifying which directory to run in specifically for my case.

lastcoolnameleft commented 5 years ago

Created feature request to Function Core tools to reflect issue I encountered due to inconsistent behavior: https://github.com/Azure/azure-functions-core-tools/issues/1489